Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Snackbar] Change the default position on desktop #21980

Merged
merged 6 commits into from
Aug 3, 2020
Merged

[Snackbar] Change the default position on desktop #21980

merged 6 commits into from
Aug 3, 2020
+51 −48

Conversation

kodai3
Copy link
Contributor

@kodai3 kodai3 commented Jul 28, 2020 •
edited by oliviertassinari
Loading

Breaking change

  • The notification now displays at the bottom left on large screens.
    It better matches the behavior of Gmail, Google Keep, material.io, etc.
    You can restore the previous behavior with:

    -<Snackbar />
+<Snackbar anchorOrigin={{ vertical: 'bottom', horizontal: 'center' }} />

  • I have followed (at least) the PR section of the contributing guide.

This is in the v5 breaking change scope

[Snackbar] Change default position. Change the default position of the snackbar on desktop to bottom left. This will better be aligned to the behavior of material.io, Gmail, Google Keep, notistack, etc.

creating PR as i'm in favor of this proposal

eps1lon
eps1lon previously requested changes Jul 28, 2020
View reviewed changes
Copy link
Member

@eps1lon eps1lon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests should reflect this change since they're now failing.

packages/material-ui/src/Snackbar/Snackbar.js Outdated Show resolved Hide resolved
@mui-pr-bot
Copy link

mui-pr-bot commented Jul 28, 2020 •
edited
Loading

Details of bundle changes

Generated by 🚫 dangerJS against 6c4aece

oliviertassinari
oliviertassinari requested changes Jul 30, 2020
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you deviating from the current tradeoff? Why using JavaScript when we can use the CSS media queries to change the position of the snackbar? Wouldn't we use CSS to better handle the initial paint?

@oliviertassinari oliviertassinari added component: snackbar This is the name of the generic UI component, not the React module! breaking change design: material This is about Material Design, please involve a visual or UX designer in the process labels Jul 30, 2020
@github-actions github-actions bot mentioned this pull request Jul 30, 2020
Closed
@kodai3
Copy link
Contributor Author

kodai3 commented Jul 30, 2020 •
edited
Loading

Why are you deviating from the current tradeoff? Why using JavaScript when we can use the CSS media queries to change the position of the snackbar? Wouldn't we use CSS to better handle the initial paint?

I had a short-sighted mind. I went for JS simply because I use them when working on our project often (which should be fixed).

changed like this for now (bb9c2d5) (i have to add like anchorOriginTopDefault)
but, maybe we should find better name for default for consistency.
(and how we should consider as desktop too)

@oliviertassinari
Copy link
Member

@kodai3 What do you think of the proposed changes?

@oliviertassinari oliviertassinari merged commit e9793db into mui:next Aug 3, 2020
@oliviertassinari
Copy link
Member

Well done

@oliviertassinari oliviertassinari mentioned this pull request Aug 3, 2020
Closed
@eps1lon eps1lon added this to the v5 milestone Aug 4, 2020
@eps1lon eps1lon mentioned this pull request Aug 5, 2020
Closed
42 tasks
@hzhz hzhz mentioned this pull request Feb 16, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Apr 13, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Apr 27, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Jun 10, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Jan 17, 2022
Open
@hzhz hzhz mentioned this pull request Aug 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

@eps1lon eps1lon eps1lon left review comments

Assignees
No one assigned
Labels
breaking change component: snackbar This is the name of the generic UI component, not the React module! design: material This is about Material Design, please involve a visual or UX designer in the process
Projects
None yet
Milestone
v5-beta
Development

Successfully merging this pull request may close these issues.
4 participants
@kodai3 @mui-pr-bot @oliviertassinari @eps1lon